From 70280285bf67b1d8fd8e9bbbd614ed906e891752 Mon Sep 17 00:00:00 2001
From: Niko Matsakis <niko@alum.mit.edu>
Date: Sat, 13 Jun 2015 22:07:10 -0400
Subject: [PATCH] some tests

---
 src/parser/mod.rs  | 47 +++++++++++++++++++++++++++++++---------------
 src/parser/test.rs | 36 ++++++++++++++++++++++++++++++-----
 2 files changed, 63 insertions(+), 20 deletions(-)

diff --git a/src/parser/mod.rs b/src/parser/mod.rs
index a60c2b9..f06d792 100644
--- a/src/parser/mod.rs
+++ b/src/parser/mod.rs
@@ -26,7 +26,7 @@ rusty_peg! {
             (<from:LITERAL>, "=>", <to:LITERAL>, ";") => (from, to);
 
         NONTERMINAL: GrammarItem =
-            (<n:ID>, <t:[NONTERMINAL_TYPE]>, "=", <a:ALTERNATIVES>) => {
+            (<n:ID>, <t:[NONTERMINAL_TYPE]>, "=", <a:ALTERNATIVES>, ";") => {
                 GrammarItem::Nonterminal(NonterminalData { name: n,
                                                            type_decl: t,
                                                            alternatives: a })
@@ -47,7 +47,7 @@ rusty_peg! {
             (<a:ALTERNATIVE>) => vec![a];
 
         ALTERNATIVESN: Vec<Alternative> =
-            ("{", <a:{ALTERNATIVE}>, "}", ";") => a;
+            ("{", <a:{ALTERNATIVE}>, "}") => a;
 
         ALTERNATIVE: Alternative =
             (<s:{SYMBOL_ARG}>, <a:[ACTION]>) => Alternative {
@@ -75,10 +75,24 @@ rusty_peg! {
                 SymbolArg { symbol: sym, highlight: SymbolHighlight::None }
             };
 
+        SYMBOL_ARG0: SymbolArg =
+            (NAMED_SYMBOL / ANON_SYMBOL / NONE_SYMBOL0);
+
+        NONE_SYMBOL0: SymbolArg =
+            (<sym:SYMBOL0>) => {
+                SymbolArg { symbol: sym, highlight: SymbolHighlight::None }
+            };
+
         // Symbols
 
         SYMBOL: Symbol =
-            (PLUS_SYMBOL / QUESTION_SYMBOL / STAR_SYMBOL / TERMINAL_SYMBOL / NT_SYMBOL);
+            (PLUS_SYMBOL0 / PLUS_SYMBOLN /
+             QUESTION_SYMBOL0 / QUESTION_SYMBOLN /
+             STAR_SYMBOL0 / STAR_SYMBOLN /
+             SYMBOL0);
+
+        SYMBOL0: Symbol =
+            (TERMINAL_SYMBOL / NT_SYMBOL);
 
         TERMINAL_SYMBOL: Symbol =
             (<l:LITERAL>) => Symbol::Terminal(l);
@@ -86,20 +100,23 @@ rusty_peg! {
         NT_SYMBOL: Symbol =
             (<l:ID>) => Symbol::Nonterminal(l);
 
-        PLUS_SYMBOL: Symbol =
-            (<v:SYMBOL_EXPR>, "+") => Symbol::Plus(v);
+        PLUS_SYMBOL0: Symbol =
+            (<v:SYMBOL_ARG0>, "+") => Symbol::Plus(SymbolExpr { args: vec![v] });
 
-        QUESTION_SYMBOL: Symbol =
-            (<v:SYMBOL_EXPR>, "?") => Symbol::Question(v);
+        PLUS_SYMBOLN: Symbol =
+            (<v:SYMBOL_EXPRN>, "+") => Symbol::Plus(v);
 
-        STAR_SYMBOL: Symbol =
-            (<v:SYMBOL_EXPR>, "*") => Symbol::Question(v);
+        QUESTION_SYMBOL0: Symbol =
+            (<v:SYMBOL_ARG0>, "?") => Symbol::Question(SymbolExpr { args: vec![v] });
 
-        SYMBOL_EXPR: SymbolExpr =
-            (SYMBOL_EXPR1 / SYMBOL_EXPRN);
+        QUESTION_SYMBOLN: Symbol =
+            (<v:SYMBOL_EXPRN>, "?") => Symbol::Question(v);
 
-        SYMBOL_EXPR1: SymbolExpr =
-            (<s:SYMBOL_ARG>) => SymbolExpr { args: vec![s] };
+        STAR_SYMBOL0: Symbol =
+            (<v:SYMBOL_ARG0>, "*") => Symbol::Star(SymbolExpr { args: vec![v] });
+
+        STAR_SYMBOLN: Symbol =
+            (<v:SYMBOL_EXPRN>, "*") => Symbol::Question(v);
 
         SYMBOL_EXPRN: SymbolExpr =
             ("(", <s:{SYMBOL_ARG}>, ")") => SymbolExpr { args: s };
@@ -209,7 +226,7 @@ pub fn parse_type_name(text: &str) -> TypeName {
     rusty_peg::Symbol::parse_complete(&TYPE_NAME, &mut parser, text).unwrap()
 }
 
-pub fn parse_grammar(text: &str) -> Grammar {
+pub fn parse_grammar(text: &str) -> Result<Grammar,rusty_peg::Error> {
     let mut parser = Parser::new(());
-    rusty_peg::Symbol::parse_complete(&GRAMMAR, &mut parser, text).unwrap()
+    rusty_peg::Symbol::parse_complete(&GRAMMAR, &mut parser, text)
 }
diff --git a/src/parser/test.rs b/src/parser/test.rs
index a4dea52..d8d152e 100644
--- a/src/parser/test.rs
+++ b/src/parser/test.rs
@@ -8,10 +8,36 @@ fn type_name() {
 
 #[test]
 fn empty_grammar() {
-    let x = parse_grammar(
-        r#"grammar Foo { } "#);
-    assert_eq!(
-        format!("{:?}", x),
-        "Grammar { type_name: TypeName { module: [], type_name: \"Foo\", parameters: [] }, items: [] }");
+    assert!(parse_grammar(r#"grammar Foo { }"#).is_ok());
+}
+
+#[test]
+fn nonterminal0() {
+    assert!(parse_grammar(r#"grammar Foo { Expr = Alt; }"#).is_ok());
+}
+
+#[test]
+fn incorrect_paren() {
+    assert!(parse_grammar(r#"grammar Foo { Expr = (Alt); }"#).is_err());
+}
+
+#[test]
+fn paren_with_plus() {
+    assert!(parse_grammar(r#"grammar Foo { Expr = (Alt)+; }"#).is_ok());
+}
+
+#[test]
+fn paren_with_plus_and_anon() {
+    assert!(parse_grammar(r#"grammar Foo { Expr = (<Alt>)+; }"#).is_ok());
+}
+
+#[test]
+fn named_choice() {
+    assert!(parse_grammar(r#"grammar Foo { Expr = <n:Alt>; }"#).is_ok());
+}
+
+#[test]
+fn named_choice_plus() {
+    assert!(parse_grammar(r#"grammar Foo { Expr = <n:Alt+>; }"#).is_ok());
 }