select code coverage

src/select/mod.rs

@@ -995,8 +995,30 @@ impl<'a, 'b> NodeVisitor for Selector<'a, 'b> {
                     .push(Some(ExprTerm::Number(Number::from_f64(*v).unwrap())));
             }
             ParseToken::Filter(ref ft) => {
-                if let Some(Some(ref right)) = self.terms.pop() {
+                let ref right = match self.terms.pop() {
-                    if let Some(Some(left)) = self.terms.pop() {
+                    Some(Some(right)) => right,
+                    Some(None) => ExprTerm::Json(
+                        None,
+                        match &self.current {
+                            Some(current) => current.to_vec(),
+                            _ => unreachable!(),
+                        },
+                    ),
+                    _ => panic!("empty term right"),
+                };
+
+                let left = match self.terms.pop() {
+                    Some(Some(left)) => left,
+                    Some(None) => ExprTerm::Json(
+                        None,
+                        match &self.current {
+                            Some(current) => current.to_vec(),
+                            _ => unreachable!(),
+                        },
+                    ),
+                    _ => panic!("empty term left"),
+                };
+
                 let mut ret = None;
                 match ft {
                     FilterToken::Equal => left.eq(right, &mut ret),
@@ -1012,12 +1034,6 @@ impl<'a, 'b> NodeVisitor for Selector<'a, 'b> {
                 if let Some(e) = ret {
                     self.terms.push(Some(e));
                 }
-                    } else {
-                        unreachable!()
-                    }
-                } else {
-                    unreachable!()
-                }
             }
             ParseToken::Range(from, to, step) => {
                 if !self.terms.is_empty() {

tests/filter.rs

@@ -343,6 +343,22 @@ fn op_complex() {
     );
 }
 
+#[test]
+fn op_compare() {
+    setup();
+
+    for path in [
+        r#"$[?("1" == 1)]"#,
+        r#"$[?(1 == "1")]"#,
+        r#"$[?(true == 1)]"#,
+        r#"$[?(@ == 1)]"#,
+    ]
+    .iter()
+    {
+        select_and_then_compare(path, json!({}), json!([Value::Null]));
+    }
+}
+
 #[test]
 fn example() {
     setup();