diff --git a/src/keys/ed25519-class.js b/src/keys/ed25519-class.js index 2305008..ec57209 100644 --- a/src/keys/ed25519-class.js +++ b/src/keys/ed25519-class.js @@ -2,9 +2,9 @@ const sha = require('multihashing-async/src/sha') const protobuf = require('protons') -const multibase = require('multibase') const errcode = require('err-code') const uint8ArrayEquals = require('uint8arrays/equals') +const uint8ArrayToString = require('uint8arrays/to-string') const crypto = require('./ed25519') const pbm = protobuf(require('./keys.proto')) @@ -85,7 +85,7 @@ class Ed25519PrivateKey { */ async id () { const hash = await this.public.hash() - return multibase.encode('base58btc', hash).toString().slice(1) + return uint8ArrayToString(hash, 'base58btc') } /** diff --git a/test/keys/ed25519.spec.js b/test/keys/ed25519.spec.js index 7104654..e457b33 100644 --- a/test/keys/ed25519.spec.js +++ b/test/keys/ed25519.spec.js @@ -80,9 +80,9 @@ describe('ed25519', function () { }) it('key id', async () => { + const key = await crypto.keys.unmarshalPrivateKey(fixtures.verify.privateKey) const id = await key.id() - expect(id).to.exist() - expect(id).to.be.a('string') + expect(id).to.eql('QmUawW9qzMrBBiMrWQQMvoatadKZ9F4EwZCAMKnt3STLtz') }) it('should export a password encrypted libp2p-key', async () => { diff --git a/test/keys/rsa.spec.js b/test/keys/rsa.spec.js index cdc5fe4..c5756d2 100644 --- a/test/keys/rsa.spec.js +++ b/test/keys/rsa.spec.js @@ -59,9 +59,9 @@ describe('RSA', function () { }) it('key id', async () => { + const key = await crypto.keys.unmarshalPrivateKey(uint8ArrayFromString('CAASqAkwggSkAgEAAoIBAQCk0O+6oNRxhcdZe2GxEDrFBkDV4TZFZnp2ly/dL1cGMBql/8oXPZgei6h7+P5zzfDq2YCfwbjbf0IVY1AshRl6B5VGE1WS+9p1y1OZxJf5os6V1ENnTi6FTcyuBl4BN8dmIKOif0hqgqflaT5OhfYZDXfbJyVQj4vb2+Stu2Xpph3nwqAnTw/7GC/7jrt2Cq6Tu1PoZi36wSwEPYW3eQ1HAYxZjTYYDXl2iyHygnTcbkGRwAQ7vjk+mW7u60zyoolCm9f6Y7c/orJ33DDUocbaGJLlHcfd8bioBwaZy/2m7q43X8pQs0Q1/iwUt0HHZj1YARmHKbh0zR31ciFiV37dAgMBAAECggEADtJBNKnA4QKURj47r0YT2uLwkqtBi6UnDyISalQXAdXyl4n0nPlrhBewC5H9I+HZr+zmTbeIjaiYgz7el1pSy7AB4v7bG7AtWZlyx6mvtwHGjR+8/f3AXjl8Vgv5iSeAdXUq8fJ7SyS7v3wi38HZOzCEXj9bci6ud5ODMYJgLE4gZD0+i1+/V9cpuYfGpS/gLTLEMQLiw/9o8NSZ7sAnxg0UlYhotqaQY23hvXPBOe+0oa95zl2n6XTxCafa3dQl/B6CD1tUq9dhbQew4bxqMq/mhRO9pREEqZ083Uh+u4PTc1BeHgIQaS864pHPb+AY1F7KDvPtHhdojnghp8d70QKBgQDeRYFxo6sd04ohY86Z/i9icVYIyCvfXAKnaMKeGUjK7ou6sDJwFX8W97+CzXpZ/vffsk/l5GGhC50KqrITxHAy/h5IjyDODfps7NMIp0Dm9sO4PWibbw3OOVBRc8w3b3i7I8MrUUA1nLHE1T1HA1rKOTz5jYhE0fi9XKiT1ciKOQKBgQC903w+n9y7M7eaMW7Z5/13kZ7PS3HlM681eaPrk8J4J+c6miFF40/8HOsmarS38v0fgTeKkriPz5A7aLzRHhSiOnp350JNM6c3sLwPEs2qx/CRuWWx1rMERatfDdUH6mvlK6QHu0QgSfQR27EO6a6XvVSJXbvFmimjmtIaz/IpxQKBgQDWJ9HYVAGC81abZTaiWK3/A4QJYhQjWNuVwPICsgnYvI4Uib+PDqcs0ffLZ38DRw48kek5bxpBuJbOuDhro1EXUJCNCJpq7jzixituovd9kTRyR3iKii2bDM2+LPwOTXDdnk9lZRugjCEbrPkleq33Ob7uEtfAty4aBTTHe6uEwQKBgQCB+2q8RyMSXNuADhFlzOFXGrOwJm0bEUUMTPrduRQUyt4e1qOqA3klnXe3mqGcxBpnlEe/76/JacvNom6Ikxx16a0qpYRU8OWz0KU1fR6vrrEgV98241k5t6sdL4+MGA1Bo5xyXtzLb1hdUh3vpDwVU2OrnC+To3iXus/b5EBiMQKBgEI1OaBcFiyjgLGEyFKoZbtzH1mdatTExfrAQqCjOVjQByoMpGhHTXwEaosvyYu63Pa8AJPT7juSGaiKYEJFcXO9BiNyVfmQiqSHJcYeuh+fmO9IlHRHgy5xaIIC00AHS2vC/gXwmXAdPis6BZqDJeiCuOLWJ94QXn8JBT8IgGAI', 'base64pad')) const id = await key.id() - expect(id).to.exist() - expect(id).to.be.a('string') + expect(id).to.eql('QmQgsppVMDUpe83wcAqaemKbYvHeF127gnSFQ1xFnBodVw') }) describe('key equals', () => { diff --git a/test/keys/secp256k1.spec.js b/test/keys/secp256k1.spec.js index 0b8b3b1..80dcf01 100644 --- a/test/keys/secp256k1.spec.js +++ b/test/keys/secp256k1.spec.js @@ -11,6 +11,7 @@ const keysPBM = crypto.keys.keysPBM const randomBytes = crypto.randomBytes const secp256k1Crypto = require('../../src/keys/secp256k1')(randomBytes) const uint8ArrayFromString = require('uint8arrays/from-string') +const fixtures = require('../fixtures/go-key-secp256k1') describe('secp256k1 keys', () => { let key @@ -58,9 +59,10 @@ describe('secp256k1 keys', () => { }) it('key id', async () => { + const decoded = keysPBM.PrivateKey.decode(fixtures.privateKey) + const key = await secp256k1.unmarshalSecp256k1PrivateKey(decoded.Data) const id = await key.id() - expect(id).to.exist() - expect(id).to.be.a('string') + expect(id).to.eql('QmPCyMBGEyifPtx5aa6k6wkY9N1eBf9vHK1eKfNc35q9uq') }) it('should export a password encrypted libp2p-key', async () => { @@ -254,8 +256,6 @@ describe('crypto functions', () => { }) describe('go interop', () => { - const fixtures = require('../fixtures/go-key-secp256k1') - it('loads a private key marshaled by go-libp2p-crypto', async () => { // we need to first extract the key data from the protobuf, which is // normally handled by js-libp2p-crypto