fluencelabs/js-libp2p-crypto
1
0
Fork 0
mirror of https://github.com/fluencelabs/js-libp2p-crypto synced 2025-03-15 06:31:01 +00:00
Code Issues Projects Releases Wiki Activity

fix: ed25519 PeerID generation (#186)

Browse Source 
* Fix Ed25519 PeerID generation

This commit pushes further fixes to the generation of Ed25519 peer IDs,
building upon the discussion in ipfs/js-ipfs#3591 and the subsequent
pull request libp2p/js-libp2p-crypto#185.

The purpose of this new pull request is to harmonize the encoding of
PeerIDs for Ed25519 keys such that the same new format is used
everywhere: peer IDs when assigned upon key generation, peer IDs when
shown via key listing, as well as the peer IDs displayed as IPNS names
when the key is used as the basis for an IPNS record.

Concretely, this changes the peer ID representation of Ed25519 keys from
the `Qm...` format to the newer `1...` format.

The accompanying test has been modified accordingly.

* Satisfy linter
This commit is contained in:
Nadim Kobeissi 2021-03-17 19:01:53 +01:00 committed by GitHub
parent 4e5a05a12c
commit 1c16dd3dec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
package.json
View File

@ -45,6 +45,7 @@
"keypair": "^1.0.1", "keypair": "^1.0.1",
"multibase": "^3.0.0", "multibase": "^3.0.0",
"multicodec": "^2.0.0", "multicodec": "^2.0.0",
"multihashes": "^4.0.2",
"multihashing-async": "^2.0.1", "multihashing-async": "^2.0.1",
"node-forge": "^0.10.0", "node-forge": "^0.10.0",
"pem-jwk": "^2.0.0", "pem-jwk": "^2.0.0",

7
src/keys/ed25519-class.js
View File

@ -4,8 +4,7 @@ const sha = require('multihashing-async/src/sha')
const protobuf = require('protons') const protobuf = require('protons')
const errcode = require('err-code') const errcode = require('err-code')
const uint8ArrayEquals = require('uint8arrays/equals') const uint8ArrayEquals = require('uint8arrays/equals')
const uint8ArrayToString = require('uint8arrays/to-string') const mh = require('multihashes')
const crypto = require('./ed25519') const crypto = require('./ed25519')
const pbm = protobuf(require('./keys.proto')) const pbm = protobuf(require('./keys.proto'))
const exporter = require('./exporter') const exporter = require('./exporter')
@ -84,8 +83,8 @@ class Ed25519PrivateKey {
* @returns {Promise<String>} * @returns {Promise<String>}
*/ */
async id () { async id () {
const hash = await this.public.hash() const encoding = mh.encode(this.public.bytes, 'identity')
return uint8ArrayToString(hash, 'base58btc') return await mh.toB58String(encoding)
} }
/** /**

2
test/keys/ed25519.spec.js
View File

@ -82,7 +82,7 @@ describe('ed25519', function () {
it('key id', async () => { it('key id', async () => {
const key = await crypto.keys.unmarshalPrivateKey(fixtures.verify.privateKey) const key = await crypto.keys.unmarshalPrivateKey(fixtures.verify.privateKey)
const id = await key.id() const id = await key.id()
expect(id).to.eql('QmUawW9qzMrBBiMrWQQMvoatadKZ9F4EwZCAMKnt3STLtz') expect(id).to.eql('12D3KooWLqLxEfJ9nDdEe8Kh8PFvNPQRYDQBwyL7CMM7HhVd5LsX')
}) })
it('should export a password encrypted libp2p-key', async () => { it('should export a password encrypted libp2p-key', async () => {