From 2d2f5591cf583e4e32d0e13d1f8ac218ef575c00 Mon Sep 17 00:00:00 2001 From: Akim <59872966+akim-bow@users.noreply.github.com> Date: Wed, 9 Aug 2023 20:04:22 +0700 Subject: [PATCH] chore: Fix test with node 18/20 error message (#323) * Fix test with node 18/20 error message * Run tests on node 18 and 20 * Enhance description * Fix type and obj property --------- Co-authored-by: Anatoly Laskaris --- .github/workflows/tests.yml | 2 +- .../js-peer/src/services/__test__/builtInHandler.spec.ts | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index e991e712..94271734 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -38,7 +38,7 @@ jobs: matrix: node-version: - 18.x - # - 20.x + - 20.x steps: - name: Import secrets diff --git a/packages/core/js-peer/src/services/__test__/builtInHandler.spec.ts b/packages/core/js-peer/src/services/__test__/builtInHandler.spec.ts index 9516aaec..99320670 100644 --- a/packages/core/js-peer/src/services/__test__/builtInHandler.spec.ts +++ b/packages/core/js-peer/src/services/__test__/builtInHandler.spec.ts @@ -129,6 +129,12 @@ describe('Tests for default handler', () => { // act const fn = builtInServices[req.serviceId][req.fnName]; const res = await fn(req); + + // Our test cases above depend on node error message. In node 20 error message for JSON.parse has changed. + // Simple and fast solution for this specific case is to unify both variations into node 18 version error format. + if (res.result === 'Unexpected token \'i\', "incorrect" is not valid JSON') { + res.result = 'Unexpected token i in JSON at position 0'; + } // assert expect(res).toMatchObject({