mirror of
https://github.com/fluencelabs/aquavm
synced 2025-03-15 12:30:50 +00:00
Add developer notes about PR reviewing (#255)
This commit is contained in:
parent
44c87097c7
commit
b23f1076ea
5
docs/developer-notes.md
Normal file
5
docs/developer-notes.md
Normal file
@ -0,0 +1,5 @@
|
|||||||
|
In the AquaVM we use the following conventions for PR reviewing:
|
||||||
|
- **Concept ACK** - agree with the idea and overall concept, but haven't reviewed the code changes or tested them,
|
||||||
|
- **utACK (untested ACK)** - reviewed and agree with the code changes but haven't actually tested them,
|
||||||
|
- **Tested ACK** - reviewed the code changes and have verified the functionality or a bug fix,
|
||||||
|
- **NACK** - disagree with the code changes/concept, should be accompanied by an explanation.
|
Loading…
x
Reference in New Issue
Block a user